-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize Project Naming #303
Comments
|
Big +1 for this. I was involved with the 1.0 spec, but even so never understood all the different naming. |
I agree this should be fixed. Brings all sorts of confusions. |
Hi All,
@arjantijms, Ok, so this all stems from the very beginning of the spec, I agree it has to be improved. But I've no idea why @JanWesterkamp-iJUG attempted to block the 2.1 release. |
Adding @JanWesterkamp-iJUG's comment here:
|
@JanWesterkamp-iJUG, just to make it clear, your comment is welcome, I agree with it. But I'd appreciate some community's help to resolve this inconsistency. If you or someone else has something concrete in mind - please suggest here. My own proposal is to use |
@JanWesterkamp-iJUG Sorry, I see you offered help above:
+1 |
I would like to suggest a refactoring of this project to use consistent naming.
This project uses deviating names on different locations, i.e.:
This inconsistent naming is confusing, as spec users need to know that these names are synonym!
Some of these deviations might be a result of the projects's evolution, as the original scope got extended over the time (to the original authentication aspects like authorisation and RBAC where added).
My suggestion is to rename the project to simply "MicroProfile JWT" to normalise naming, including (as much as possible) all locations (while maintaining naming conventions on different locations of course). Some of these aspects are resulting in a breaking change and with the upcoming MP 6.0 major release this can be solved properly.
@dblevins, @Emily-Jiang: I can offer to create PRs to the projects, if you like to. But some of the aspects might need additional support.
Originally, this is a finding from the review of MP 5.0, that is not addressed yet:
eclipse/microprofile#275
The text was updated successfully, but these errors were encountered: