Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP 5.0 Review Open Issues #275

Closed
JanWesterkamp-iJUG opened this issue Sep 22, 2022 · 4 comments
Closed

MP 5.0 Review Open Issues #275

JanWesterkamp-iJUG opened this issue Sep 22, 2022 · 4 comments

Comments

@JanWesterkamp-iJUG
Copy link
Contributor

The included spec list is formatted differntly (as code instead of a list of links), somehow doubled and contains typos:

https://github.com/eclipse/microprofile/blob/master/spec/src/main/asciidoc/architecture.asciidoc

Typos:
Open API -> OpenAPI (the spec repo name itself has that problem too !)
Open Tracing -> OpenTracing

JWT RBAC is the spec name, but the i.e. repo is named microprofile-jwt-auth and below the name of the chapter is MicroProfile JWT Authentication 2.0 - this is inconsistent!

Can we fix the typos, format the list as in MP 4.1 and rename the repos accordingly (this need to be done in their repos of couse)?

original message link

The spec document contains an error in the following part:

MicroProfile Rest Client 3.0
MicroProfile Rest Client provides a type-safe approach for invoking RESTful services over HTTP.
The MicroProfile Rest Client builds upon the JAX-RS 2.1 APIs for consistency and ease-of-use.

The JAX-RS 2.1 APIs reference link is outdated because of the change to Jakarta RESTful Web Services!

Should be updated according to the wording and naming in the referenced spec:

Rest Client for MicroProfile
Rationale

The MicroProfile Rest Client provides a type-safe approach to invoke RESTful services over HTTP. As much as possible the MP Rest Client attempts to use Jakarta RESTful Web Services 2.1 APIs for consistency and easier re-use.

original message link

@JanWesterkamp-iJUG
Copy link
Contributor Author

@Emily-Jiang here is the umbrella issue for my MP 5.0 review findings.

I think the best approach would be starting with a PR to fix the simple things and then create sub-issues, may be in the component specs. What do you think about it?

@Emily-Jiang
Copy link
Member

Emily-Jiang commented Sep 22, 2022

@JanWesterkamp-iJUG as mentioned on the call, I think Edwin has done the fixes already. I checked on the master branch and I think they were fixed indeed. If you see anything else, please feel free to open an issue. I will leave the other specs alone for the time being unless you have found anything else.

@Emily-Jiang
Copy link
Member

I found out this issue created by Edwin to address your issue and it was solved. I am going to close this issue as a dup of #241

@JanWesterkamp-iJUG
Copy link
Contributor Author

@Emily-Jiang: I checked @ederks85 changes and found at least one open issue regarding MP JWT - I opened an issue for that:
eclipse/microprofile-jwt-auth#303

I will continue checking for other open aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants