Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reddeer fixes #2222

Merged
merged 9 commits into from
Aug 30, 2023
Merged

Reddeer fixes #2222

merged 9 commits into from
Aug 30, 2023

Conversation

olkornii
Copy link
Contributor

Pull Request Checklist

Code

  • Are method-/class-/variable-names meaningful?
  • Are methods concise, not too long?
  • Are catch blocks catching precise Exceptions only (no catch all)?
  • Is copyright with correct year in new files?
  • Is there a JavaDoc in every class with description of a class and an author(and issue if suitable)?
  • Is there a link to github project issue? (if needed)

Testing

  • Does it work?
  • Are the tests green on Jenkins? Is there a link to Jenkins build?

olkornii and others added 4 commits August 30, 2023 11:19
@olkornii
"Do not automatically update dependencies from remote repositories" does
178953c 
not exist anymore in Preferences -> Maven.

Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Fixed getWidgetFromPartWhenOtherShellIsActive test
d743e1a 
Signed-off-by: Oleksii Korniienko <[email protected]>
@odockal @olkornii
Test staging eclipse update site
d0a3dd6 
Signed-off-by: Ondrej Dockal <[email protected]>
@olkornii
commented first failed
7aebf5c 
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Copy link
Contributor Author

testPR

@olkornii
Changed EAR version from 8 to 10
cb729db 
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Copy link
Contributor Author

testPR

1 similar comment
@olkornii
Copy link
Contributor Author

testPR

@olkornii
Enable JavaProjectWizardTests
6681bd4 
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Copy link
Contributor Author

testPR

3 similar comments
@olkornii
Copy link
Contributor Author

testPR

@olkornii
Copy link
Contributor Author

testPR

@olkornii
Copy link
Contributor Author

testPR

@olkornii
CodeSmells fixes
d22e9d3 
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Increased xmx from 512m to 1024m
d0044a0 
Signed-off-by: Oleksii Korniienko <[email protected]>
@olkornii
Updated Java version for JavaProjectWizardTests
f1f9197 
Signed-off-by: Oleksii Korniienko <[email protected]>
@odockal
Copy link
Member

odockal commented Aug 30, 2023

@olkornii nice patches. Let's tackle the rest in RC2. ;)

@odockal odockal merged commit d1f5339 into eclipse:master Aug 30, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odockal odockal odockal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olkornii @odockal