Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with new Scheduler #14

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Compatibility with new Scheduler #14

merged 6 commits into from
Jun 11, 2024

Conversation

reuterbal
Copy link

This will likely create conflicts with #13 and I'm happy to rebase over that one if the PR is updated and ready to be merged.

Changes here:

  • Fix the validation method in TL
  • Update CMake macros for Loki
  • Remove a non-applicable bundle option
  • Update Loki config files for compatibility with new Scheduler
  • Add an arch for Github actions runners
  • Update the bundle bootstrapping to use the open-source ecbundle repository

@reuterbal reuterbal mentioned this pull request Feb 23, 2024
Merged
@reuterbal
Copy link
Author

@mlange05 Can we get this merged?

mlange05
mlange05 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I'm assuming the CI will be triggered from the Loki side then? In any case, yes, GTG.

@reuterbal
Copy link
Author

This repository doesn't have any CI at the moment. Loki will include it in the regression tests once TL problems are fixed

@reuterbal reuterbal merged commit 4ea7bf8 into develop Jun 11, 2024
@reuterbal reuterbal deleted the nabr-new-loki-scheduler branch October 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlange05 mlange05 mlange05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reuterbal @mlange05