SCC: Better logging and warning for "bad" code constructs #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/125/index.html |
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 92.10% 92.10%
=======================================
Files 89 89
Lines 16540 16546 +6
=======================================
+ Hits 15234 15240 +6
Misses 1306 1306
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
reuterbal
force-pushed
the
naml-scc-more-trafo-logging
branch
from
c75cbea
to
6098cdb
Compare
reuterbal
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR stack on top of #124 and should only be reviewed once this is merged.
A small housekeeping PR that homogenises the detailed logging info in Loki-SCC passes (after the removal of the wrappers), and adds some more warnings for "correct, but bad" code constructs that should be resolved in the original source. This includes private array declarations at the "vector" level and wrong ordering of parallel directives (
loop vectorinsideloop seq).Please note that the latter requires more advanced features (proper source-level subroutine inlining) that are currently still under development to truly mitigate. In the meantime, removing some of these by hand seems to have small positive effects in ec-physics regression.