fix for argument shape regarding module imports

[MichaelSt98]

Currently, there is a problem regarding the array argument shape transformation used within the SCC transformations.

E.g. regarding

MODULE DRIVER_MOD
USE KERNEL_A_MOD, ONLY: KERNEL_A
IMPLICIT NONE
CONTAINS
  SUBROUTINE driver(nlon, nlev, a, b, c)
    INTEGER, INTENT(IN)   :: nlon, nlev  ! Dimension sizes
    INTEGER, PARAMETER    :: n = 5
    REAL, INTENT(INOUT)   :: a(nlon)
    REAL, INTENT(INOUT)   :: b(nlon,nlev)
    REAL, INTENT(INOUT)   :: c(nlon,n)

    call kernel_a(a, b, c)

  END SUBROUTINE driver

END MODULE DRIVER_MOD

MODULE KERNEL_A_MOD
IMPLICIT NONE
CONTAINS
  SUBROUTINE kernel_a(a, b, c)
    USE VAR_MODULE_MOD, only: n
    REAL, INTENT(INOUT)   :: a(:)
    REAL, INTENT(INOUT)   :: b(:,:)
    REAL, INTENT(INOUT)   :: c(:,:)

  END SUBROUTINE kernel_a

END MODULE KERNEL_A_MOD

with

MODULE VAR_MODULE_MOD
INTEGER, PARAMETER    :: n = 5
END MODULE VAR_MODULE_MOD

the transformation without fix would create a definition INTEGER, PARAMETER,INTENT(IN) :: n = 5 in the routine kernel_a which causes a compilation error.

This is fixed by checking additionally for module imports (of both the routine and module).

[github-actions]

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/148/index.html

[codecov]

Codecov Report

Merging #148 (28c8be9) into main (0db337c) will decrease coverage by 0.04%.
Report is 67 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   92.15%   92.12%   -0.04%     
==========================================
  Files          90       89       -1     
  Lines       16653    16512     -141     
==========================================
- Hits        15347    15212     -135     
+ Misses       1306     1300       -6     

Flag	Coverage Δ
lint_rules	96.22% <ø> (+0.26%)	⬆️
loki	92.05% <ø> (-0.05%)	⬇️
transformations	91.71% <100.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
transformations/transformations/argument_shape.py	92.72% <100.00%> (+0.57%)	⬆️

... and 17 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

[mlange05]

Clean, neat and well tested. Very nice! GTG from me.

[reuterbal]

Fully agreed, GTG!