Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique ID to Node #153

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add unique ID to Node #153

wants to merge 4 commits into from

Commits on Sep 29, 2023

  1. Add unique ID to Node: _uid 

    See Issue ecmwf-ifs#123, copy follows:

Currently, the only mechanism for differentiating two string-identical
but distinct nodes is the .source property. However this property is only
instantiated for parsed nodes; if two identical but distinct nodes are
generated in a transformation there is no method (apart from the object
id) to tell them apart.

The above could be remedied by adding a uid attribute to the Node class.
The uid property would be generated every time a node is created. This
means that even copies of the same node would have different values of
uid, unless overridden via a constructor argument.
    @joscao
    joscao committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c94f555 View commit details
    Browse the repository at this point in the history

  2. Force comments to also have a _uid 

    I see no reason why Comments node wouldnt call the __post_init__ in
their __post_init__ like all other nodes do.
    @joscao
    joscao committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    14af9d2 View commit details
    Browse the repository at this point in the history

  3. Fix broad-exception-caught

    @joscao
    joscao committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    e1b72a1 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary fixture

    @joscao
    joscao committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f479128 View commit details
    Browse the repository at this point in the history