Bugfix: Memory error in Statement functions test #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/159/index.html |
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 92.13% 92.13%
=======================================
Files 90 90
Lines 16714 16714
=======================================
Hits 15399 15399
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. |
reuterbal
force-pushed
the
nabr-debug-ci-segfaults
branch
from
768308e
to
e0005ad
Compare
reuterbal
force-pushed
the
nabr-debug-ci-segfaults
branch
from
91093ca
to
3a321a1
Compare
reuterbal
changed the title
mlange05
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had seen random failures of CI tests with a segfault, which typically went away when re-running the test. I have tracked this down to the statement functions test, where an uninitialised value was used for the index when writing to an array.
The test has been fixed and the problem hasn't resurfaced so far, hoping this was the root cause.