Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector section trimming in driver loop #169

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

awnawab
Copy link
Contributor

@awnawab awnawab commented Oct 12, 2023

This PR is a one-line fix to the vector section trimming within the driver loop. The corresponding test is parametrised to show the effect of vector section trimming.

@github-actions
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/169/index.html

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #169 (6e615f0) into main (ede5135) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          90       90           
  Lines       16689    16689           
=======================================
+ Hits        15374    15375    +1     
+ Misses       1315     1314    -1     
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.09% <ø> (ø)
transformations 91.40% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../transformations/single_column_coalesced_vector.py 98.70% <100.00%> (+0.64%) ⬆️

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great - fills in a test coverage gap and restores the functionality. GTG from my side but I let one of the other SCC experts agree.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, neat and nicely tested. GTG :shipit:

@reuterbal reuterbal merged commit f861d8c into main Oct 12, 2023
12 checks passed
@reuterbal reuterbal deleted the naan-driver-trim-vector branch October 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants