Display dataflow analysis (if attached) in IR graph #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 90 90
Lines 16690 16697 +7
=======================================
+ Hits 15379 15386 +7
Misses 1311 1311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Provided a test case. e34b98f |
joscao
changed the title
reuterbal
approved these changes
Nov 8, 2023
| uses_symbols, | ||
| "]", | ||
| ) | ||
| except (RuntimeError, KeyError, AttributeError) as _: |
There was a problem hiding this comment.
I think you can simply skip the as _ if you're not planning to use the exception
reuterbal
added
the
ready for merge
reuterbal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the IR graph representation by also showing lives,uses and defines when
dataflow_analysisis attached