-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pool_allocator handles range indices #193
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 92.16% 92.17%
=======================================
Files 93 93
Lines 16793 16795 +2
=======================================
+ Hits 15478 15480 +2
Misses 1315 1315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, this is great! I have manually verified regression tests offline and everything looks ok. GTG!
(I suggest a squash merge for this.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only checked this visually, but the test coverage looks convincing. GTG from me too.
Added a bit of code to handle range indices in array declarations and modified tests accordingly.