Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool_allocator handles range indices #193

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

rolfhm
Copy link
Contributor

@rolfhm rolfhm commented Nov 24, 2023

Added a bit of code to handle range indices in array declarations and modified tests accordingly.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (539e57f) 92.16% compared to head (bc5e4e7) 92.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   92.16%   92.17%           
=======================================
  Files          93       93           
  Lines       16793    16795    +2     
=======================================
+ Hits        15478    15480    +2     
  Misses       1315     1315           
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.13% <ø> (ø)
transformations 91.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks, this is great! I have manually verified regression tests offline and everything looks ok. GTG!
(I suggest a squash merge for this.)

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Nov 29, 2023
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked this visually, but the test coverage looks convincing. GTG from me too.

@reuterbal reuterbal merged commit 32e5745 into ecmwf-ifs:main Nov 29, 2023
8 of 12 checks passed
@rolfhm rolfhm deleted the sbrm-range-indices-in-stack branch December 11, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants