Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce flag to allow removing all derived types #215

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MichaelSt98
Copy link
Collaborator

from procedure signatures (via replacing by its members).

I will almost certainly rely on this for F2LowLevelGPU transformation(s), at least until different/more sophisticated solutions exist. Anyway, I think this is a useful in general.

Introducing: all_derived_types : bool, optional

Whether to remove all derived types from procedure signatures by
replacing the derived type arguments using its member variables or
only the "relevant" ones, referring to derived types with array
members or nested derived types (default: False).

Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/215/index.html

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c86b83a) 92.26% compared to head (bdf3993) 92.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          96       96           
  Lines       17124    17125    +1     
=======================================
+ Hits        15799    15800    +1     
  Misses       1325     1325           
Flag Coverage Δ
lint_rules 96.21% <ø> (ø)
loki 92.24% <ø> (ø)
transformations 91.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful addition, neatly tested and well documented!

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Jan 22, 2024
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree, well done! GTG from me.

@mlange05 mlange05 merged commit 3af8578 into main Jan 24, 2024
12 checks passed
@mlange05 mlange05 deleted the nams_transform_all_derived_type branch January 24, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants