Overwrite frontend options on a per-file basis in Scheduler config #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/233/index.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nabr-the-new-scheduler #233 +/- ##
==========================================================
- Coverage 92.72% 92.71% -0.02%
==========================================================
Files 95 95
Lines 17800 17825 +25
==========================================================
+ Hits 16505 16526 +21
- Misses 1295 1299 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
reviewed
Mar 4, 2024
|
|
||
| The resulting `dict` contains overwrites that have been provided | ||
| in the :attr:`frontend_args` of the config. | ||
| """ |
There was a problem hiding this comment.
Might be useful to list arguments here. Was briefly wondering here what path pertained to.
There was a problem hiding this comment.
Thanks, good point. I've commited an updated docstring
mlange05
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to overwrite frontend options on a per-file basis in the Scheduler config. This allows for example to switch on preprocessing for individual files only (e.g., for those that are not valid Fortran without preprocessing), or to overwrite the frontend parser. The latter was the missing piece to successfully run CLOUDSC regression with OMNI.