-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further frontend performance optimisations #234
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/234/index.html |
mlange05
force-pushed
the
naml-frontend-improvements-part-deux
branch
from
March 7, 2024 16:04
dadfafb
to
e75fedb
Compare
As variable declarations can be encoutered out of sequence, we have rebuild `DeferredTypeSymbols` after parsing the full spec, so that the symbols might be rebuild correctly. This commit adjusts a test to capture this and adds a small custom mapper to do this in place.
mlange05
force-pushed
the
naml-frontend-improvements-part-deux
branch
from
March 8, 2024 13:30
e75fedb
to
c534e4c
Compare
This was referenced Mar 9, 2024
Yes, indeed this had been done via separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small round of tricks to improve the performance of the
sanitize_ir
utility and theFP
frontend to reduce the frontend processing time for large input subroutines. Primarily, this PR focuses on using fast in-place transformers for the necessary IR sanitisation and avoid using the explicit rescoping for the FParser frontend by attaching the scopes on first IR node creation.In more detail:
inplace=True
rescope_symbols
on the finalised IR when creating subroutinesOn the pathological test case we the following improvements:
Integration note: PR is currently passing ECphysics regression, but not local test base. Will attempt to fix local tests ASAP, but filing draft now to trigger test base. Initial bulk-parse in EC-physics also seems to improve with this.