Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'reverse_traversal=True' to DerivedTypeArgumentsTransformation manifest #238

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

MichaelSt98
Copy link
Collaborator

... with a proper test using the scheduler

Copy link

github-actions bot commented Mar 5, 2024

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/238/index.html

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 92.71%. Comparing base (970e0b6) to head (6b8c210).
Report is 53 commits behind head on main.

Files Patch % Lines
loki/bulk/item.py 92.54% 34 Missing ⚠️
loki/bulk/scheduler.py 95.58% 12 Missing ⚠️
loki/bulk/configure.py 93.93% 6 Missing ⚠️
loki/program_unit.py 78.57% 3 Missing ⚠️
loki/sourcefile.py 83.33% 2 Missing ⚠️
loki/transform/build_system_transform.py 33.33% 2 Missing ⚠️
transformations/transformations/data_offload.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
+ Coverage   92.47%   92.71%   +0.23%     
==========================================
  Files          95       95              
  Lines       17473    17828     +355     
==========================================
+ Hits        16159    16529     +370     
+ Misses       1314     1299      -15     
Flag Coverage Δ
lint_rules 96.22% <ø> (ø)
loki 92.71% <93.81%> (+0.27%) ⬆️
transformations 91.95% <95.23%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this. Looks great, nothing that stands out to me.

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Mar 5, 2024
@reuterbal reuterbal force-pushed the nabr-the-new-scheduler branch 2 times, most recently from 5dbd1fb to 1e03830 Compare March 22, 2024 10:07
Base automatically changed from nabr-the-new-scheduler to main March 22, 2024 10:41
@reuterbal reuterbal added rebase required Rebase required for the PR branch to resolve conflicts and removed ready for merge This PR has been approved and is ready to be merged labels Mar 25, 2024
@mlange05 mlange05 force-pushed the nams_derived_type_trafo_traversal branch from 6b8c210 to ae9d15b Compare March 25, 2024 13:52
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Many thanks for you patience. GTG :shipit:

@mlange05 mlange05 added ready for merge This PR has been approved and is ready to be merged and removed rebase required Rebase required for the PR branch to resolve conflicts labels Mar 25, 2024
@reuterbal reuterbal changed the title DerivedTypeArgumentsTransformation to 'reverse_traversal=True' Add 'reverse_traversal=True' to DerivedTypeArgumentsTransformation manifest Mar 25, 2024
@reuterbal reuterbal merged commit f61ef6e into main Mar 25, 2024
11 checks passed
@reuterbal reuterbal deleted the nams_derived_type_trafo_traversal branch March 25, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants