Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGEX frontend: white space and nesting bugfix #274

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

reuterbal
Copy link
Collaborator

Discovered with IFS source files.

Two small fixes for the REGEX frontend patterns, with tests that triggered before the corresponding changes:

  • Multiple or no white space around the end statement for procedures
  • Matching of module procedures is now lazy to match internal subprograms in module procedures

@reuterbal reuterbal requested a review from mlange05 April 8, 2024 10:03
Copy link

github-actions bot commented Apr 8, 2024

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/274/index.html

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.83%. Comparing base (6b58fe7) to head (92c0c5c).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         102      102           
  Lines       18121    18121           
=======================================
  Hits        16823    16823           
  Misses       1298     1298           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 92.80% <ø> (ø)
transformations 92.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and behaves correctly with ec-physics regression. GTG :shipit:

@mlange05 mlange05 added the ready for merge This PR has been approved and is ready to be merged label Apr 11, 2024
@reuterbal reuterbal merged commit 5c356ca into main Apr 11, 2024
12 checks passed
@reuterbal reuterbal deleted the nabr-regex-fixes branch April 11, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants