SCCBaseTransformation.get_integer_variable now also checks module imports
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/279/index.html |
awnawab
force-pushed
the
naan-get-integer
branch
from
45058ec
to
3438c41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 92.88% 92.88% -0.01%
==========================================
Files 102 102
Lines 18253 18252 -1
==========================================
- Hits 16954 16953 -1
Misses 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
added
the
rebase required
reuterbal
requested changes
Apr 10, 2024
| @@ -796,6 +804,9 @@ def test_single_column_coalesced_hoist_openacc(frontend, horizontal, vertical, b | |||
| analysis = HoistTemporaryArraysAnalysis(dim_vars=(vertical.size,)) | |||
| synthesis = SCCHoistTemporaryArraysTransformation(block_dim=blocking) | |||
|
|
|||
| # Check that blocking size has not been redefined | |||
| assert driver.symbol_map[blocking.size].type.module | |||
There was a problem hiding this comment.
Is this missing some kind of comparison maybe? E.g., driver.symbol_map[blocking.size].type.module.lower() == 'block_dim_mod'?
Comment on lines
119
to
121
| if name in routine.symbol_map: | ||
| v_index = routine.symbol_map[name] | ||
| else: |
There was a problem hiding this comment.
Since constructing these maps is expensive, could we maybe do it like this?
Suggested change
| if name in routine.symbol_map: | |
| v_index = routine.symbol_map[name] | |
| else: | |
| v_index = routine.symbol_map.get(name) | |
| if v_index is None: |
awnawab
force-pushed
the
naan-get-integer
branch
from
3438c41
to
b6fc44a
Compare
awnawab
force-pushed
the
naan-get-integer
branch
from
b6fc44a
to
47314ba
Compare
reuterbal
removed
the
rebase required
reuterbal
approved these changes
Apr 12, 2024
reuterbal
added
the
ready for merge
|
Confirmed clean with ec-physics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_integer_variableutility inSCCBaseTransformationnow also checks if the integer has been imported via a module.