Preserve import statement functions - take II

[awnawab]

A second take on preserving statement function imports via c-style headers. This time, rather than only renaming imports with intfb in their name, we now skip all imports with func in their name. I do realise that this introduces another IFS specific naming convention to the DependencyTransformation, and this probably needs generalising.

[github-actions]

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/283/index.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (f4a0c33) to head (1301302).
Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   92.82%   92.88%   +0.05%     
==========================================
  Files         102      102              
  Lines       18220    18247      +27     
==========================================
+ Hits        16913    16948      +35     
+ Misses       1307     1299       -8     

Flag	Coverage Δ
lint_rules	96.39% <ø> (ø)
loki	92.85% <100.00%> (+0.06%)	⬆️
transformations	92.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reuterbal]

Thanks, as discussed offline this seems like a justifiable variant of baking in IFS-specific knowledge but minimal impact. The blanket check for func in the import name might create problems, though, so I've suggested a slightly different approach.

[reuterbal]

Sorry for nitpicking further but just realized that this may fail in pretty trivial cases, e.g., #include "myfunc.intfb.h" will now not be processed... 😅

Should we apply the IFS-specific knowledge a bit more explicitly, e.g. like this?

target_symbol, *suffices = im.module.lower().split('.', maxsplit=1)
if targets and target_symbol in targets and 'func.h' not in suffices:

Note that this works even if no . is in the module name at all, returning suffices as an empty list.
That way this becomes a very loose restriction specific to the problem of statement functions and in-line with the coding standards.

[awnawab]

Ah of course, well spotted and apologies for the clumsy oversight 😅

[reuterbal]

Thanks for taking care of the requested changes and bonus points for capturing this edge case in the tests :)

[mlange05]

Looks great and is confirmed clean with ec-physics regression. GTG