Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update to links from static doc pages #312

Merged
merged 5 commits into from
May 12, 2024
Merged

Conversation

mlange05
Copy link
Collaborator

@mlange05 mlange05 commented May 4, 2024

Filing early to get the resulting change and errors logs. Please ignore for now...

General documentation update following the move of sub-packages. This primarily does three things:

  1. Update static links in the documentation pages to sub-packages that have moved
  2. General update of docstrings that trigger silent errors or warnings in the docs build
  3. Addition of sub-package docstrings to give a brief overview of the respective sub-packages (the auto-generated API list looked empty to me).

Unfortunately, I didn't get everything in the docstring clean-up commit, and there are still a few warnings I do not understand. The overall impact should be net-positive though.

Copy link

github-actions bot commented May 4, 2024

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/312/index.html

@mlange05 mlange05 force-pushed the naml-docs-update branch 2 times, most recently from 44d9634 to e022c98 Compare May 4, 2024 05:08
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (cca7312) to head (055f580).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   95.11%   95.12%           
=======================================
  Files         165      165           
  Lines       35130    35143   +13     
=======================================
+ Hits        33415    33429   +14     
+ Misses       1715     1714    -1     
Flag Coverage Δ
lint_rules 95.08% <100.00%> (-1.31%) ⬇️
loki 95.07% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlange05 mlange05 force-pushed the naml-docs-update branch 13 times, most recently from b1e2708 to 7958714 Compare May 6, 2024 08:40
@mlange05 mlange05 requested a review from reuterbal May 6, 2024 08:48
@mlange05 mlange05 marked this pull request as ready for review May 6, 2024 08:48
Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, many thanks! I've flagged a few typos, otherwise good to go!

Just-in-Time compilation utilities used in the Loki test base.

These allow compilation and wrapping of generated Fortran source code
using `f90wrap <https://github.com/jameskermode/f90wrap>` for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
using `f90wrap <https://github.com/jameskermode/f90wrap>` for
using `f90wrap <https://github.com/jameskermode/f90wrap>`_ for

Comment on lines 8 to 9
Expression layer of the two-level Loki IR based on `Pymbolic
<https://github.com/inducer/pymbolic`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Expression layer of the two-level Loki IR based on `Pymbolic
<https://github.com/inducer/pymbolic`.
Expression layer of the two-level Loki IR based on
`Pymbolic <https://github.com/inducer/pymbolic>`_.

Frontend parsers that create Loki IR from input Fortran code.

This includes code sanitisation utilities and several frontend parser
interfaces, including the REGEX-frontend that used for fast source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interfaces, including the REGEX-frontend that used for fast source
interfaces, including the REGEX-frontend that is used for fast source


This includes code sanitisation utilities and several frontend parser
interfaces, including the REGEX-frontend that used for fast source
code exploration in large call trees.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
code exploration in large call trees.
code exploration in large call and dependency trees.

"""
Sub-package with supported source code transformation passes.

This sub-package includes general source code trnasformations and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This sub-package includes general source code trnasformations and
This sub-package includes general source code transformations and


This sub-package provides the :any:`Scheduler` class that allows Loki
transformations to be applied over large source trees. For this it
provides the basic :any:`Transformation` and :and:`Pipeline` classes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
provides the basic :any:`Transformation` and :and:`Pipeline` classes
provides the basic :any:`Transformation` and :any:`Pipeline` classes

@mlange05
Copy link
Collaborator Author

Ok, thanks @reuterbal . Pushed fixes and rebased.

Copy link
Collaborator

@reuterbal reuterbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There was a 1-letter typo still, which I took the liberty of fixing myself. Going in...

@reuterbal reuterbal merged commit f3e7d90 into main May 12, 2024
11 checks passed
@reuterbal reuterbal deleted the naml-docs-update branch May 12, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants