Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_pragma_parameters: Fix parsing clauses without parentheses in the tail string #324

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

reuterbal
Copy link
Collaborator

This fixes the issue reported in #317

@reuterbal reuterbal linked an issue Jun 10, 2024 that may be closed by this pull request
@reuterbal reuterbal requested a review from mlange05 June 10, 2024 15:23
@reuterbal reuterbal mentioned this pull request Jun 10, 2024
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/324/index.html

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (7959f5b) to head (08e598d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files         168      168           
  Lines       35645    35659   +14     
=======================================
+ Hits        33928    33942   +14     
  Misses       1717     1717           
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and test is very neat. GTG from me. :shipit:

@mlange05 mlange05 added the ready for merge This PR has been approved and is ready to be merged label Jun 14, 2024
@mlange05 mlange05 merged commit 181f6b2 into main Jun 14, 2024
12 checks passed
@mlange05 mlange05 deleted the 317-acc-seq-bug branch June 14, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

acc seq bug
2 participants