Fix wrong classification as StatementFunction in translation to Loki IR #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/327/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 95.15% 95.18% +0.02%
==========================================
Files 168 168
Lines 35454 35645 +191
==========================================
+ Hits 33737 33929 +192
+ Misses 1717 1716 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
force-pushed
the
326-fparser-frontend-array-assignments-may-wrongfully-be-interpreted-as-statementfunction
branch
from
6db70d3
to
3526b9f
Compare
reuterbal
changed the title
|
I think this is ready for another look @mlange05 |
mlange05
approved these changes
Jun 14, 2024
mlange05
deleted the
326-fparser-frontend-array-assignments-may-wrongfully-be-interpreted-as-statementfunction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh....
Found with scan2m.F90, correctly removing all misclassifications now.