Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linter warnings for inline calls with interface block imported from header with func.h suffix #332

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

reuterbal
Copy link
Collaborator

Another beautiful edge case but this time purely in Linter recipes:

  • apparently, interface blocks may not only be declared in .intfb.h headers, but also in .func.h headers
  • inline calls with string parameters can actually be identified as inline calls (rather than array subscripts) by fparser

@reuterbal reuterbal requested a review from mlange05 June 12, 2024 20:03
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/332/index.html

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (b9be6f6) to head (b766924).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         168      168           
  Lines       35417    35432   +15     
=======================================
+ Hits        33700    33715   +15     
  Misses       1717     1717           
Flag Coverage Δ
lint_rules 96.39% <100.00%> (+0.01%) ⬆️
loki 95.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nifty Fparser trick! Looks clean and neat as always, GTG from me. :shipit:

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Jun 13, 2024
@reuterbal reuterbal merged commit 8a9c4ec into main Jun 13, 2024
12 checks passed
@reuterbal reuterbal deleted the fix-linter-warning-for-func-include-inline-calls branch June 13, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants