Transformations: Internalise IdemTransformation
#360
Conversation
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/360/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 95.38% 95.39%
=======================================
Files 175 177 +2
Lines 37065 37094 +29
=======================================
+ Hits 35356 35385 +29
Misses 1709 1709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
force-pushed
the
naml-internalize-idem
branch
from
5d000b0
to
4743b2a
Compare
|
@reuterbal FYI, I piggy-backed another small MacOS timeout disable-fix in this one, as these keep failing sporadically. |
|
@reuterbal Ok, I added two more small tweaks that were needed for the CLOUDSC loki generalisation. With this, I can recover most of the standards behaviour, so should be ok now. |
There was a problem hiding this comment.
Thanks, this looks great. Looking forward to the end result of this...
Coverage reports that the call to normalize_range_indexing from the SanitiseTransformation is not invoked by any tests. Maybe it would be easy to amend one of the existing tests to apply this?
loki/transformations/idempotence.py
Outdated
|
|
||
| class IdemTransformation(Transformation): | ||
| """ | ||
| A custom transformation pipeline that primarily does nothing, |
There was a problem hiding this comment.
Even secondarily it does nothing, I think ;-P
mlange05
force-pushed
the
naml-internalize-idem
branch
from
ad3b65c
to
922546d
Compare
Also adds a simple test that it indeed does nothing!
mlange05
force-pushed
the
naml-internalize-idem
branch
from
922546d
to
d2b1e59
Compare
|
Ok, apologies, this last piggy-backed change has turned this into a bit of a mess. I've now stripped the change regarding |
|
Yes, looks all good. Thanks for this! |
This change move the
IdemTransformationthat we often use for testing to theloki.transformationssub-package and fixes a configure bug when omitting theoptionsentry in TOML(!)-based configuration entries. This is in preparation for the full move to config-file transformation configuration in CLOUDSC.