Transformations: ResolveAssociateTransformer re-write to in-place substitution #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlange05
changed the title
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/387/index.html |
mlange05
changed the title
mlange05
force-pushed
the
naml-resolve-assoc-new
branch
3 times, most recently
from
61d511a
to
78f1241
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 186 186
Lines 38894 38977 +83
=======================================
+ Hits 37152 37234 +82
- Misses 1742 1743 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
force-pushed
the
naml-resolve-assoc-new
branch
from
e21c136
to
4724955
Compare
Instead of finding all symbols and substituting them with their inverse-association, we now simply run over each symbol, find its inverse from the `.scope` and apply in-place. This requires the substitution to be written as a symbol mapper. As an addition feature, we can now do partial resolution in associate bodies, where only a select sub-region of the code has its associated symbols resolved. I've added a test to this extend.
This adds "auto-fixer" behaviour for call.arguments and call.kwarguments, which makes it safe to always iterate them.
mlange05
force-pushed
the
naml-resolve-assoc-new
branch
from
4724955
to
4445dd0
Compare
reuterbal
approved these changes
Oct 8, 2024
| """ | ||
| An :any:`collections.OrderedDict` of associated expressions. | ||
| """ | ||
| return CaseInsensitiveDict((str(v), k) for k, v in self.associations) |
There was a problem hiding this comment.
Can we simply "stringify" v here, considering that an association can in theory be a rather complex expression?
reuterbal
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR sits on top of PR #372 and requires this to be merged first.This PR re-writes the
ResolveAssociateTransformerand switches it to acting entirely in-place. For this, instead of finding all symbols and substituting them with their inverse-association, we now simply run over each symbol, find its inverse from the.scopeand apply in-place. This requires the substitution to be written as a symbol mapper.As an addition feature, we can now do partial resolution in associate bodies, where only a select sub-region of the code has its associated symbols resolved. I've added a test to this extend.
And on top of that I've refactored the imports in the associated test.
Edit: I've also had a to introduce "auto-fixer" behaviour for
CallStatementnodes and a corresponding test. This now ensure thatcall.argumentsandcall.kwargumentsare always (possibly empty) tuples and can thus safely be iterated. This fixed some fallout in the transpile tests.