Skip privatization of arrays with existing data declarations #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/389/index.html |
awnawab
force-pushed
the
naan-skip-annotate
branch
from
cf89b7c
to
cf0f893
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 95.57% 95.57% -0.01%
==========================================
Files 201 201
Lines 39810 39833 +23
==========================================
+ Hits 38050 38071 +21
- Misses 1760 1762 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
awnawab
force-pushed
the
naan-skip-annotate
branch
2 times, most recently
from
e01d916
to
3ee37ed
Compare
reuterbal
requested changes
Oct 8, 2024
| @@ -221,14 +266,16 @@ def device_alloc_column_locals(cls, routine, column_locals): | |||
| routine.body.prepend((ir.Comment(''), pragma, ir.Comment(''))) | |||
There was a problem hiding this comment.
[no action required] This is not covered in tests, so we don't seem to be testing this.
(@mlange05 for info)
awnawab
force-pushed
the
naan-skip-annotate
branch
from
3ee37ed
to
dbbf717
Compare
reuterbal
reviewed
Oct 14, 2024
reuterbal
approved these changes
Oct 14, 2024
…find_driver_loops and annotate_driver_loop
reuterbal
force-pushed
the
naan-skip-annotate
branch
from
dbbf717
to
66215b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays with existing data declarations should not be privatized in the driver gang loop. This PR adds the functionality to gather information from encompassing
!$acc dataregions and filter out the relevant arrays.