Fix representation of array return type in OMNI frontend #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/391/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 95.52% 95.53%
=======================================
Files 186 186
Lines 38956 38974 +18
=======================================
+ Hits 37214 37233 +19
+ Misses 1742 1741 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichaelSt98
approved these changes
Oct 9, 2024
mlange05
approved these changes
Oct 9, 2024
mlange05
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translation of the OMNI AST into the Loki IR dropped the shape information of the return type, representing the return value always as scalar. This PR fixes the behaviour and adds a test.
Small caveat is that with OMNI the dimension information will always be put on the variable, i.e., both
real, dimension(n) :: ret_valreal :: ret_val(n)will always be represented as the latter. But since string-identical parse-unparse cycle is not achievable with OMNI anyway, I consider this not too important. Please shout if you disagree.
This PR should fix the problems that @MichaelSt98 encountered with OMNI in #378.