Improve representation of procedure pointers (fix #393) #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/399/index.html |
reuterbal
force-pushed
the
393-problem-with-procedure-pointers
branch
from
0da240f
to
98ee8ca
Compare
reuterbal
force-pushed
the
393-problem-with-procedure-pointers
branch
from
c71c308
to
f052f73
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 95.54% 95.58% +0.04%
==========================================
Files 188 201 +13
Lines 39471 39847 +376
==========================================
+ Hits 37711 38087 +376
Misses 1760 1760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mlange05
approved these changes
Oct 16, 2024
mlange05
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by the fgen issue reported in #393. This looked first like the issue was simply that we did not account for the case that procedure information might be missing when generating the code for procedure declarations.
However, while trying to sort this out across frontends, I noticed that it should be perfectly possible to recognize the interface as a procedure in this situation, and that the handling of procedure types for symbols declared in procedure declarations was very inconsistent and partially wrong. This should fix this discrepancy.