Remove Maxeler transpilation module #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/405/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 95.57% 96.02% +0.44%
==========================================
Files 201 197 -4
Lines 39810 38981 -829
==========================================
- Hits 38050 37430 -620
+ Misses 1760 1551 -209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
OK, coverage seems not to deteriorate as a result of this, meaning we don't seem to have had any indirect coverage purely due to the maxeler transpilation. |
mlange05
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Filing this as a draft PR for now to assess impact on test coverage.The Maxeler transpilation capability was developed during the EuroEXA project. However, since the completion of the project we do no longer have access to the commercially licenced simulation software nor any Maxeler Dataflow Engine hardware, therefore testing these capabilities is no longer possible. Hence, I propose removing the transpilation module from Loki.