Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update f90wrap to 0.2.15 as minimum to ensure compatibility with numpy 2.0+ #407

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

reuterbal
Copy link
Collaborator

@reuterbal reuterbal commented Oct 15, 2024

Note: Draft PR to trigger tests

What it says on the tin:

  • Update f90wrap to 0.2.15 as minimum version, which restores compatibility with numpy 2.0 (https://github.com/jameskermode/f90wrap/releases/tag/v0.2.15)
  • That allows to remove the restriction numpy<1.24
  • Which allows to enable Python 12 as supported Python version
  • ...and Python 12 added to the Github actions test matrix

@reuterbal reuterbal force-pushed the nabr-update-numpy branch 2 times, most recently from 5673318 to 51de5f0 Compare October 15, 2024 10:58
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/407/index.html

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (b6eb817) to head (eedf2f1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   95.57%   95.57%   -0.01%     
==========================================
  Files         201      201              
  Lines       39810    39833      +23     
==========================================
+ Hits        38050    38071      +21     
- Misses       1760     1762       +2     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuterbal reuterbal changed the title Python 12 compatibility and update f90wrap to 0.2.15 as minimum to ensure compatibility with numpy 2.0+ Update f90wrap to 0.2.15 as minimum to ensure compatibility with numpy 2.0+ Oct 15, 2024
@reuterbal
Copy link
Collaborator Author

OK, the impact of the changes in f90wrap for support of Python 12 seems to be rather extensive: it mandates switching to meson (which somehow doesn't get installed reliably), requires ninja as build backend (which definitely doesn't get installed reliably) and somehow forgets to compile / use the source files before compiling the wrapper library.

We don't have Python 3.12 available on the cluster, yet, but the problems can be replicated locally on MacOS. Hence, I limit the scope of this PR to supporting latest numpy via enforcing a recent f90wrap version, and we can look into Python 3.12 support separately.

@reuterbal reuterbal marked this pull request as ready for review October 15, 2024 19:31
Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible. GTG :shipit:

@mlange05 mlange05 added the ready for merge This PR has been approved and is ready to be merged label Oct 16, 2024
@reuterbal reuterbal merged commit 7187899 into main Oct 16, 2024
13 checks passed
@reuterbal reuterbal deleted the nabr-update-numpy branch October 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants