Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved output of initial state #62

Merged
merged 14 commits into from
Dec 2, 2024
Merged

Conversation

dietervdb-meteo
Copy link
Contributor

@dietervdb-meteo dietervdb-meteo commented Nov 28, 2024

This PR closes #61 and #48.
A new function reduce() is added to the Output class, which projects a state to the last step in the multi-step dimension.

This function is then used to define write_initial_state() as a combination of reduce() and write_state() for the netcdf, raw and plot output.

The naming of the raw output is brought in line with the naming of the plot output.

The default write_initial_state config setting is now true.


📚 Documentation preview 📚: https://anemoi-inference--62.org.readthedocs.build/en/62/

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (ecfb2bc) to head (1f1ec4d).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #62   +/-   ##
========================================
  Coverage    75.00%   75.00%           
========================================
  Files            1        1           
  Lines            4        4           
========================================
  Hits             3        3           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dietervdb-meteo
Copy link
Contributor Author

Questions:

  1. Currently default config is not to write the intial state to output. Shouldn't it be better if the default is to write the initial state?
  2. Plot output does the projection to last step of in the multi-step dimension explicitly (and for all states, not just the initial state). This could now be done using reduce() and possibly applied only in write_initial_state. Should we change this?

b8raoult
b8raoult previously approved these changes Nov 29, 2024
@dietervdb-meteo
Copy link
Contributor Author

dietervdb-meteo commented Nov 29, 2024

Upon (private) communication with the reviewer it was decided the answer to both questions above is 'yes'. The code was adapted accordingly.

@b8raoult b8raoult merged commit e18fafd into develop Dec 2, 2024
120 checks passed
@b8raoult b8raoult deleted the feature/initial-state-output branch December 2, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add initial state to netcdf output.
3 participants