-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved output of initial state #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #62 +/- ##
========================================
Coverage 75.00% 75.00%
========================================
Files 1 1
Lines 4 4
========================================
Hits 3 3
Misses 1 1 ☔ View full report in Codecov by Sentry. |
Questions:
|
b8raoult
previously approved these changes
Nov 29, 2024
Upon (private) communication with the reviewer it was decided the answer to both questions above is 'yes'. The code was adapted accordingly. |
b8raoult
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #61 and #48.
A new function
reduce()
is added to theOutput
class, which projects a state to the last step in the multi-step dimension.This function is then used to define
write_initial_state()
as a combination ofreduce()
andwrite_state()
for the netcdf, raw and plot output.The naming of the raw output is brought in line with the naming of the plot output.
The default
write_initial_state
config setting is nowtrue
.📚 Documentation preview 📚: https://anemoi-inference--62.org.readthedocs.build/en/62/