Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netcdf output #98

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix netcdf output #98

merged 2 commits into from
Jan 10, 2025

Conversation

HCookie
Copy link
Member

@HCookie HCookie commented Jan 6, 2025

Ensure variable creation

@HCookie HCookie requested a review from b8raoult January 6, 2025 14:05
@HCookie HCookie self-assigned this Jan 6, 2025
@ecmwf ecmwf deleted a comment from codecov-commenter Jan 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (2385b2d) to head (6dd8da2).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #98   +/-   ##
========================================
  Coverage    98.03%   98.03%           
========================================
  Files            3        3           
  Lines           51       51           
========================================
  Hits            50       50           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dietervdb-meteo dietervdb-meteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least functionally this seems to work. I just ran a successful test with this branch that removed an earlier tp error present in the netcdf output, and which I assume this PRs aim it was to fix.

I might not be qualified to review code quality, so if that would be required maybe an additional review by someone more appropriate for that would be good.

Otherwise no objections to merging from me.

Thanks for the work, I would like netcdf output to work as soon as possible.

@b8raoult b8raoult merged commit 38cb2b5 into develop Jan 10, 2025
71 checks passed
@b8raoult b8raoult deleted the fix/netcdf-variables branch January 10, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants