Modifications for DAOS backend. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wdeconinck
approved these changes
Jan 25, 2024
pmaciel
reviewed
Jan 25, 2024
| (*current_)->close(); | ||
| current_++; | ||
| openCurrent(); | ||
| return read1(buffer, length); | ||
| if (n <= 0) { |
There was a problem hiding this comment.
I can imagine there is good reason to interpret n <= 0 :-)
pmaciel
approved these changes
Jan 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #106 +/- ##
===========================================
- Coverage 61.93% 61.93% -0.01%
===========================================
Files 899 899
Lines 49646 49648 +2
Branches 3728 3730 +2
===========================================
Hits 30750 30750
- Misses 18896 18898 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.