Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests on aarch64 #155

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix tests on aarch64 #155

merged 1 commit into from
Dec 23, 2024

Conversation

alphagocc
Copy link
Contributor

strcmp has strange return values on aarch64
we can't simply assume it is -1/0/1

@FussyDuck
Copy link

FussyDuck commented Dec 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mcakircali mcakircali requested a review from danovaro December 23, 2024 10:14
mcakircali
mcakircali approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@mcakircali mcakircali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@danovaro danovaro added the approved-for-ci Approved for CI run label Dec 23, 2024
@danovaro danovaro merged commit 2cf7ebe into ecmwf:develop Dec 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcakircali mcakircali mcakircali approved these changes

@danovaro danovaro Awaiting requested review from danovaro

Assignees
No one assigned
Labels
approved-for-ci Approved for CI run contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alphagocc @FussyDuck @mcakircali @danovaro