Add defensive pointer boundary checks to log targets to avoid SEGFAUL… #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are still discussing a way to make the ChannelBuffer threadsafe (or maybe to find another solution) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #95 +/- ##
===========================================
- Coverage 62.80% 62.80% -0.01%
===========================================
Files 790 790
Lines 45196 45193 -3
===========================================
- Hits 28386 28383 -3
Misses 16810 16810 ☔ View full report in Codecov by Sentry. |
…TS with raceconditions
geier1993
force-pushed
the
bugfix/89-segmentation-fault-caused-by-buffer-overflow-in-channelbuffer
branch
from
67706a9 to
d7d610e
Compare
dsarmany
approved these changes
Nov 29, 2023
simondsmart
reviewed
Dec 6, 2023
| @@ -69,9 +67,10 @@ void ChannelBuffer::reset() { | |||
|
|
|||
| bool ChannelBuffer::dumpBuffer() { | |||
| if (target_) { | |||
| target_->write(pbase(), pptr()); | |||
| // Explicitly check that `pptr()` is not larger than end of buffer. Racecondition can end up adding larger values. | |||
There was a problem hiding this comment.
Can we be explicit that this is a race condition in the std library, rather than here.
simondsmart
deleted the
bugfix/89-segmentation-fault-caused-by-buffer-overflow-in-channelbuffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TS with raceconditions #89