Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export version symbol to Python API again #47

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

amotl
Copy link

@amotl amotl commented Oct 23, 2021

Hi there,

first things first: Thanks a stack for conceiving and maintaining this excellent software.

While working on the GribMagic program, which uses the Magics Python bindings to libMagPlus, we discovered that the version symbol somehow stopped being exported starting with libMagPlus 4.7.0. We reported about our observations in detail at ecmwf/magics-python#39.

So, when accessing dll.version from Python, it croaked like

AttributeError: dlsym(0x7f7f59e05120, version): symbol not found

In turn, this also made selfcheck's report slightly bogus:

$ python -m Magics selfcheck
Found: Magics 'You are using an old version of magics ( < 4.0.0)'.
Your system is ready.

With this small patch, everything is in order again:

$ python -m Magics selfcheck
Found: Magics 'Magics 4.9.3'.
Your system is ready.
>>> import Magics.macro
>>> Magics.macro.version()
'Magics 4.9.3'

With kind regards,
Andreas.

This symbol somehow got lost starting with libMagPlus 4.7.0. When
calling it from Python, it croaked like::

    AttributeError: dlsym(0x7f7f59e05120, version): symbol not found
@FussyDuck
Copy link

FussyDuck commented Oct 23, 2021

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants