Support optimal encoding of constant string columns greater than 8 characters long #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomHodson
force-pushed
the
feature/long-constant-srings
branch
from
0b93e85 to
15bc01f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #22 +/- ##
===========================================
- Coverage 87.30% 87.18% -0.13%
===========================================
Files 189 189
Lines 15020 14947 -73
Branches 0 1352 +1352
===========================================
- Hits 13113 13031 -82
- Misses 1907 1916 +9 ☔ View full report in Codecov by Sentry. |
The new codec is enabled for reading but odc will not write data with the new codec unless "ODC_ENABLE_WRITING_LONG_STRING_CODEC" is set in the environment. This is to give some time for installations in the wild to update before files containing the new code are produced by default.
TomHodson
force-pushed
the
feature/long-constant-srings
branch
from
da0d3fc to
8f52ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.