Specify UTF-8 encoding in Python script #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error on Windows
Works just as well, no need for an extra import
edent
reviewed
Sep 26, 2024
update_readme.py
Outdated
| @@ -122,7 +122,7 @@ | |||
| print(f"README.md updated with {len(svg_list)} icons.") | |||
|
|
|||
| # Replace the tables in the REFERENCE document | |||
| with open('REFERENCE.md','r+') as f: | |||
| with open('README.md','r+', encoding="utf-8") as f: | |||
edent
reviewed
Sep 26, 2024
update_readme.py
Outdated
| @@ -135,7 +135,7 @@ | |||
| print(f"REFERENCE.md updated.") | |||
|
|
|||
| # Replace the table in the CHECK document | |||
| with open('CHECK.html','r+') as f: | |||
| with open('README.md','r+', encoding="utf-8") as f: | |||
There was a problem hiding this comment.
Weird, wonder how those happened. Thanks for the catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python seems to assume CP-1252 or something similar on Windows, which breaks on emoji. This ensures that UTF-8 will be used.