Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeeksforGeeks Logo #811 #817

Closed
wants to merge 1 commit into from

Conversation

Himanshuch8055
Copy link

@Eiim
Copy link
Collaborator

Eiim commented Oct 1, 2024

The submitted SVG doesn't currently follow the requirements in CONTRIBUTING.md. Also, there shouldn't be any need to edit the Python script, if there is an issue with it, submit that as a separate PR.

@Eiim Eiim mentioned this pull request Oct 1, 2024
@Himanshuch8055
Copy link
Author

Can you update and provide more detailed instructions for the CONTRIBUTING guide? It's currently difficult to understand.

@Eiim
Copy link
Collaborator

Eiim commented Oct 1, 2024

I'm not sure what you're looking for. The problems with your SVG are:

  1. It does not follow this format:
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

You might look at other SVGs in the repository as examples. The fill="#fff" can be changed depending on the logo (although here I don't think it should be), the rest should remain the same except the part you put in the ....

  1. The file is 2,648 bytes, which is more than the 1,024 byte limit.

The other issue is the updates to the update_readme.py file, which should not generally be changed in a PR adding a new logo. If there are any issues with that script, they should be addressed separately.

@edent edent added the spam label Oct 3, 2024
@edent edent closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants