Skip to content

Commit

Permalink
fcoll/vulcan: fix memory leak
Browse files Browse the repository at this point in the history
we didn't correctly free the fh->f_aggr_list array in the vulcan file_write_all file.
Thanks @andymwood for reporting the issue and @ggouaillardet for identifying the cause for the leak.

Fixes Issue open-mpi#12677 (at least partially)

Signed-off-by: Edgar Gabriel <[email protected]>
  • Loading branch information
edgargabriel committed Sep 6, 2024
1 parent e25e897 commit 3fde6af
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ompi/mca/fcoll/vulcan/fcoll_vulcan_file_write_all.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,8 +768,10 @@ exit :
}
free(broken_iov_arrays);
free(fh->f_procs_in_group);
free(fh->f_aggr_list);
fh->f_procs_in_group=NULL;
fh->f_procs_per_group=0;
fh->f_aggr_list=NULL;
free(result_counts);
free(reqs);

Expand Down

0 comments on commit 3fde6af

Please sign in to comment.