Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rudimentary support for rendering SQLRow typedesc #1428

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Add rudimentary support for rendering SQLRow typedesc #1428

merged 2 commits into from
Dec 12, 2024

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Dec 12, 2024

In tandem with edgedb/edgedb-rust#368

msullivan
msullivan approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to want it to be a table printer eventually?

@1st1
Copy link
Member Author

1st1 commented Dec 12, 2024

Are we going to want it to be a table printer eventually?

100% we must before 6.0. This is just a temporary rendering to let us debug / develop

@1st1 1st1 closed this Dec 12, 2024
@1st1 1st1 reopened this Dec 12, 2024
@1st1 1st1 merged commit 978f853 into master Dec 12, 2024
17 checks passed
@1st1 1st1 deleted the sql_row branch December 12, 2024 17:27
msullivan pushed a commit that referenced this pull request Dec 17, 2024
@1st1 @msullivan
Add rudimentary support for rendering SQLRow typedesc (#1428)
d9cbe72
msullivan pushed a commit that referenced this pull request Dec 17, 2024
@1st1 @msullivan
Add rudimentary support for rendering SQLRow typedesc (#1428)
bf2684d
msullivan added a commit that referenced this pull request Dec 17, 2024
@msullivan
edgedb-cli 6.1.0
9351999 
Changes
=======

* Support printing postgis data.
  (by @dnwpark in b59e8de for #1425)

* Add rudimentary support for rendering SQLRow typedesc
  (by @1st1 in bf2684d for #1428)

* Add `using future simple_scoping;` by default to 6.0 projects
  (by @msullivan in 21d01f5 for #1427)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljazerzen aljazerzen aljazerzen approved these changes

@msullivan msullivan msullivan approved these changes

@elprans elprans Awaiting requested review from elprans

@mmastrac mmastrac Awaiting requested review from mmastrac

@dnwpark dnwpark Awaiting requested review from dnwpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1st1 @msullivan @aljazerzen