Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth helpers READMEs to include full EdgeDB Auth setup #1085

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

beerose
Copy link
Member

@beerose beerose commented Aug 26, 2024

No description provided.

@beerose beerose requested a review from scotttrinh August 26, 2024 16:31
packages/auth-express/readme.md Outdated Show resolved Hide resolved
packages/auth-express/readme.md Outdated Show resolved Hide resolved
packages/auth-express/readme.md Outdated Show resolved Hide resolved
@beerose beerose requested a review from scotttrinh August 28, 2024 14:45
Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have accidentally been sitting on this small piece of feedback for months, 🙈


Before adding EdgeDB auth to your Express server, you will first need to enable the `auth` extension in your EdgeDB schema, and have configured the extension with some providers.

1. Enable the EdgeDB Auth extension in your schema:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These step numbers end up being indented in a weird way compared to the explanatory text. Maybe we don't need the numbers, just have them as subheadings?

Suggested change
1. Enable the EdgeDB Auth extension in your schema:
#### Enable the EdgeDB Auth extension in your schema

wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants