Gel prisma #1162
Open
Gel prisma #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpetrovykh
force-pushed
the
gel-prisma
branch
2 times, most recently
from
9fa1ca5 to
80ad3b5
Compare
scotttrinh
reviewed
Dec 19, 2024
packages/generate/src/gel-prisma.ts
Outdated
| import type { Client } from "edgedb"; | ||
| import * as fs from "node:fs"; | ||
|
|
||
| const WARNINGS: string[] = []; |
There was a problem hiding this comment.
Maybe instead of collecting them, just print them into stderr as they happen?
There was a problem hiding this comment.
I think you can print them to stdout with console.log, tbh. I don't think our debug output in our generators are very principled about that sort of thing.
packages/generate/src/gel-prisma.ts
Outdated
Comment on lines
151
to
152
| const types = <JSONType[]>JSON.parse(await client.queryJSON(INTRO_QUERY)); | ||
| const modules = <string[]>JSON.parse(await client.queryJSON(MODULE_QUERY)); |
There was a problem hiding this comment.
Why queryJSON -> JSON.parse instead of query?
There was a problem hiding this comment.
This was mostly a translation from the Python version of this tool. There I was collecting things into dicts rather than native objects so that I could access things uniformly via [ ] and not worry about fields. I realize that in JS version this is not necessary, so a query is probably right in this spot.
vpetrovykh
force-pushed
the
gel-prisma
branch
from
67410dc to
e020c82
Compare
Add the `prisma` command to the list of valid @edgedb/generate commands. It requires a `--file` and some way of connecting the client (DSN or whatever other method). The generated Prisma schema will be output as specified by `--file`.
Test the basic CRUD capability of the exposed Prisma models.
vpetrovykh
force-pushed
the
gel-prisma
branch
from
e020c82 to
85e2033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.