Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): add nuxt template settings #875
base: master
Are you sure you want to change the base?
feat(nuxt): add nuxt template settings #875
Changes from 2 commits
4fa5028
d4e8db6
0843c3b
7700b0e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think we should have these recipes be starting point for any kind of app, not really an example app, if that makes sense. I'd expect that the schema here is empty, and that we add the auth extension here conditionally based on options set by the user.
To that end, if you want to design a small single page that just scaffolds some very basic layout and styles, definitely do that. Probably something closer to https://github.com/nuxt/starter/tree/v3 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds great.
I started doing the "most minimal" Nuxt starter, but for Nuxt it just looks like adding
nuxt-edgedb-module
to their modules array.The rest of it is just described in
nuxt-edgedb-module
.Should I push that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in getting back to you here.
I'm not sure I understand the question but what I expect to see in these recipes is a totally empty
default.esdl
file, not even including theusing extension auth;
expression even. No migrations, no query builder code generator output, etc. These recipes should represent how you'd start day 0 on a new project, not as an example project, if that makes sense. The UI/app itself should also be minimal so that developers can quickly check that everything is working right, but nothing else.Does that make sense?