Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings #352

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Warnings #352

merged 10 commits into from
Oct 11, 2024

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Oct 8, 2024 •
edited
Loading

  • reads annotation "warnings" from CommandDataDescription,
  • logs these warnings via log crate (at warn level),
  • adds a new QueryExecutor function query_with_warnings

I'm not sure on the function name here, should it be changed to query_full or query_verbose?

@aljazerzen aljazerzen changed the title warnings Warnings Oct 8, 2024
@aljazerzen
Copy link
Contributor Author

The test is failing because the edgedb-server provided by env does not yet have std::_warn_on_call() function used to test warnings.

mmastrac
mmastrac approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aljazerzen aljazerzen merged commit a12e2ae into master Oct 11, 2024
4 checks passed
@aljazerzen aljazerzen deleted the warnings branch October 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@msullivan msullivan Awaiting requested review from msullivan

@fantix fantix Awaiting requested review from fantix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljazerzen @mmastrac