Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User menu & theme switcher update on all resolutions #262

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

diksipav
Copy link
Contributor

@diksipav diksipav commented Sep 29, 2023

Update user menu on desktop and mobile.
Update theme switcher on mobile.
Move secret-keys page to the top level /secret-keys.

@diksipav diksipav requested a review from jaclarke September 29, 2023 16:35
@jaclarke
Copy link
Member

jaclarke commented Oct 6, 2023

  • Menu items are missing the border-radius
  • Scrollbars (probably not a big issue as mobile doesn't usually have scrollbars)
  • When opening the theme switcher dropdown, the tooltip is visible on the right for a second
  • Theme select seems to be slightly taller than the menu items

image

Hey, I already fixed these things in a new commit. Will just double check the tooltips, i saw them but after screen refresh didnt see them anymore (without changes, and this only in firefox).

@jaclarke
Copy link
Member

jaclarke commented Oct 6, 2023

Was this commit meant to be in nebula-ui? Ignore this, I see the other part in the nebula-ui PR.
image

@diksipav diksipav changed the title Add shared scss file, update header font styles and modal background overlay User menu & theme switcher update on all resolutions Oct 6, 2023
@diksipav diksipav merged commit 3c569eb into main Oct 6, 2023
1 of 2 checks passed
@diksipav diksipav deleted the mobile-ui-updates branch October 6, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants