UI mobile updates #266
Merged
UI mobile updates #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use accent green color for hover/active states.
Remove theme switcher from vertical bar on desktops. Use circle mobile close btn on client settings panel. Update theme switcher to use new theme cokors.
Update colors with theme colors. Update Run & Close buttons file name to be inside common/ui/mobile/button. Create ui/mobile/cta for the big link button for mobile screens.
Update mobile button components to RoundButton and Button. Use InstanceIcon in mobile bottom nav for Instances screen.
jaclarke
reviewed
Oct 19, 2023
| @@ -153,6 +154,7 @@ export function HeaderNavCol<LinkProps>({ | |||
| /> | |||
| ) : null} | |||
| <span>{item.label}</span> | |||
| {item.selected && <CheckIcon />} | |||
There was a problem hiding this comment.
I think the check icon is meant to indicate the currently active item, not the one that's being hovered/selected.
Remove checkIcon from navbar items' dropdowns.
Use btn comp as a button or link. Update filter buttons' styles. Show filter err on mobile above the action buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.