Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relocate models dir #22

Closed
wants to merge 1 commit into from
Closed

Conversation

francis2tm
Copy link
Contributor

Introduction

To be more in line with huggingface's hub, let's store the models in cache_dir() instead of data_dir().

@francis2tm francis2tm self-assigned this Feb 6, 2024
@francis2tm
Copy link
Contributor Author

@toschoo additionally, I also suggest using here.
Or am I missing something?

@toschoo
Copy link
Contributor

toschoo commented Feb 6, 2024

I'm not sure about this. I think that where we locate our models is the data dir, not the cache dir. HF might see it as the cache. But where it is located on the computer looks like a data dir. In fact, in our concept there is no cache dir. Calling it cache is somewhat confusing. After all, it's where users put their models. Anyway, we need to review all of this when we start working on the module manager.

@francis2tm
Copy link
Contributor Author

We're going to stick with data_dir.

@francis2tm francis2tm closed this Feb 6, 2024
@francis2tm francis2tm deleted the chore/rename_data_dir branch February 6, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants