Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check profile existence before adding device/provision watcher #4971

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jinlinGuan
Copy link
Contributor

close #4957

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

Copy link

sonarcloud bot commented Oct 14, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 31.87%. Comparing base (66e3c9b) to head (a09553d).

Files with missing lines Patch % Lines
...rnal/core/metadata/application/provisionwatcher.go 0.00% 6 Missing ⚠️
internal/core/metadata/application/device.go 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4971      +/-   ##
==========================================
+ Coverage   31.84%   31.87%   +0.03%     
==========================================
  Files         265      265              
  Lines       19424    19430       +6     
==========================================
+ Hits         6185     6193       +8     
+ Misses      11822    11814       -8     
- Partials     1417     1423       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 2b1f484 into edgexfoundry:main Oct 14, 2024
6 checks passed
@jinlinGuan jinlinGuan deleted the issue-4957 branch October 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device should not be created if device profile didn't exist
3 participants