Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Using isNull field instead of nil reading value #4974

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

weichou1229
Copy link
Member

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

  • make test
  • test with simple DS

New Dependency Instructions (If applicable)

@weichou1229
Copy link
Member Author

This PR is based on the core-contracts changes edgexfoundry/go-mod-core-contracts#935

Using isNull instead of nil reading value

Signed-off-by: bruce <[email protected]>
Copy link

sonarcloud bot commented Oct 17, 2024

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 31.81%. Comparing base (0f2c1aa) to head (f2bf259).

Files with missing lines Patch % Lines
internal/pkg/infrastructure/redis/reading.go 46.66% 7 Missing and 1 partial ⚠️
internal/pkg/infrastructure/postgres/reading.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4974   +/-   ##
=======================================
  Coverage   31.80%   31.81%           
=======================================
  Files         265      265           
  Lines       19470    19484   +14     
=======================================
+ Hits         6193     6199    +6     
- Misses      11854    11861    +7     
- Partials     1423     1424    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 82350b2 into edgexfoundry:main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants