Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove idle sleep during page load #535

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

ajcasagrande
Copy link
Contributor

@ajcasagrande ajcasagrande commented Jul 6, 2022

Signed-off-by: Anthony Casagrande [email protected]

Closes #534

NOTE 1: I am not able to test this on secure mode, but on non-secure mode, the page loads almost instantly now.
NOTE 2: I have not committed the generated files

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like @badboy-huaqiao 's input just in case SetTimer is a workaround to some race condition.

Copy link
Contributor

@MonicaisHer MonicaisHer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have tested this PR with snap packaging on secure mode.
The page load takes a comparable time(2s) as before.

Copy link
Member

@badboy-huaqiao badboy-huaqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have given some views, see here, but it's ok removing them right now, we will figure out a better solution.

it's looks like this PR is ready, will close it.

@badboy-huaqiao badboy-huaqiao merged commit 260e99f into edgexfoundry:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excessive delay in environment checking on startup
4 participants